Zack's Kernel News
Making System Calls Reject Unknown Flags
Christoph Hellwig was unhappy with the fact that anyone could pass random garbage as input to system calls, without breaking anything. As a result, user code can't test system calls to see if they accept this or that input flag – they accept them all, even if they do nothing with them. He wanted to write a patch that would make system calls reject input flags that weren't actually supported.
Christoph acknowledged that this would be an application binary interface (ABI) change, which was nearly always a no-no for a few important reasons. For one thing, it made it impossible to "bisect" the kernel development tree in order to hunt down bugs that crossed the version that implemented the ABI-breaking change. More importantly, however, it would break existing user code running out in the world on everybody's system and require that code to be recompiled. This is actually a big no-no because in many cases, the people running the binaries don't have the source code anymore!
So, ABI changes are generally hit with hammers by various folks, including Linus Torvalds. In this case, Linus didn't bother addressing the ABI issue, but objected to Christoph's main point, saying:
"Probing for flags is why we *could* add things like O_NOATIME etc. – exactly because it 'just worked' with old kernels, and people could just use the new flags knowing that it was a no-op on old kernels.
The whole concept of 'probing for supported features' is very suspect. It's a bad, bad idea. Don't do it.
What kind of new flag did you even have in mind that would have such broken semantics that it would completely change the other flags? Because now I'm starting to think that the whole series has an even deeper bug: stupid new features that were badly thought out and not even described."
Christoph pointed to the atomic input/output issue as described in https://lwn.net/Articles/573092/. Linus was unimpressed, saying that in the typical case, any code that wanted atomic input/output would probably still want to perform input/output without the atomicity guarantee, in which case there were straightforward ways to handle it. He added, "My guess is that there is going to be very few O_ATOMIC users anyway, and they'll very carefully set it once and test it (or not even test it – just make it be a configuration flag and tell people 'don't ask for O_ATOMIC if your system doesn't support it')."
Meanwhile, Florian Weimer said that probing for flags was "vastly preferable to hard-coding kernel version dependencies in source or object code. Particularly if you want to move applications between different kernel versions (which seems to be all the rage right now)."
But the conversation trailed off at that point. Regardless of whether there's a decent justification for probing, it's still an ABI change, which kills it at the starting gate.
« Previous 1 2
Buy this article as PDF
(incl. VAT)
Buy Linux Magazine
Subscribe to our Linux Newsletters
Find Linux and Open Source Jobs
Subscribe to our ADMIN Newsletters
Support Our Work
Linux Magazine content is made possible with support from readers like you. Please consider contributing when you've found an article to be beneficial.
News
-
The GNU Project Celebrates Its 40th Birthday
September 27 marks the 40th anniversary of the GNU Project, and it was celebrated with a hacker meeting in Biel/Bienne, Switzerland.
-
Linux Kernel Reducing Long-Term Support
LTS support for the Linux kernel is about to undergo some serious changes that will have a considerable impact on the future.
-
Fedora 39 Beta Now Available for Testing
For fans and users of Fedora Linux, the first beta of release 39 is now available, which is a minor upgrade but does include GNOME 45.
-
Fedora Linux 40 to Drop X11 for KDE Plasma
When Fedora 40 arrives in 2024, there will be a few big changes coming, especially for the KDE Plasma option.
-
Real-Time Ubuntu Available in AWS Marketplace
Anyone looking for a Linux distribution for real-time processing could do a whole lot worse than Real-Time Ubuntu.
-
KSMBD Finally Reaches a Stable State
For those who've been looking forward to the first release of KSMBD, after two years it's no longer considered experimental.
-
Nitrux 3.0.0 Has Been Released
The latest version of Nitrux brings plenty of innovation and fresh apps to the table.
-
Linux From Scratch 12.0 Now Available
If you're looking to roll your own Linux distribution, the latest version of Linux From Scratch is now available with plenty of updates.
-
Linux Kernel 6.5 Has Been Released
The newest Linux kernel, version 6.5, now includes initial support for two very exciting features.
-
UbuntuDDE 23.04 Now Available
A new version of the UbuntuDDE remix has finally arrived with all the updates from the Deepin desktop and everything that comes with the Ubuntu 23.04 base.