Zack's Kernel News
Making System Calls Reject Unknown Flags
Christoph Hellwig was unhappy with the fact that anyone could pass random garbage as input to system calls, without breaking anything. As a result, user code can't test system calls to see if they accept this or that input flag – they accept them all, even if they do nothing with them. He wanted to write a patch that would make system calls reject input flags that weren't actually supported.
Christoph acknowledged that this would be an application binary interface (ABI) change, which was nearly always a no-no for a few important reasons. For one thing, it made it impossible to "bisect" the kernel development tree in order to hunt down bugs that crossed the version that implemented the ABI-breaking change. More importantly, however, it would break existing user code running out in the world on everybody's system and require that code to be recompiled. This is actually a big no-no because in many cases, the people running the binaries don't have the source code anymore!
So, ABI changes are generally hit with hammers by various folks, including Linus Torvalds. In this case, Linus didn't bother addressing the ABI issue, but objected to Christoph's main point, saying:
"Probing for flags is why we *could* add things like O_NOATIME etc. – exactly because it 'just worked' with old kernels, and people could just use the new flags knowing that it was a no-op on old kernels.
The whole concept of 'probing for supported features' is very suspect. It's a bad, bad idea. Don't do it.
What kind of new flag did you even have in mind that would have such broken semantics that it would completely change the other flags? Because now I'm starting to think that the whole series has an even deeper bug: stupid new features that were badly thought out and not even described."
Christoph pointed to the atomic input/output issue as described in https://lwn.net/Articles/573092/. Linus was unimpressed, saying that in the typical case, any code that wanted atomic input/output would probably still want to perform input/output without the atomicity guarantee, in which case there were straightforward ways to handle it. He added, "My guess is that there is going to be very few O_ATOMIC users anyway, and they'll very carefully set it once and test it (or not even test it – just make it be a configuration flag and tell people 'don't ask for O_ATOMIC if your system doesn't support it')."
Meanwhile, Florian Weimer said that probing for flags was "vastly preferable to hard-coding kernel version dependencies in source or object code. Particularly if you want to move applications between different kernel versions (which seems to be all the rage right now)."
But the conversation trailed off at that point. Regardless of whether there's a decent justification for probing, it's still an ABI change, which kills it at the starting gate.
« Previous 1 2
Buy this article as PDF
(incl. VAT)
Buy Linux Magazine
Subscribe to our Linux Newsletters
Find Linux and Open Source Jobs
Subscribe to our ADMIN Newsletters
Support Our Work
Linux Magazine content is made possible with support from readers like you. Please consider contributing when you’ve found an article to be beneficial.
News
-
TUXEDO Computers Unveils Linux Laptop Featuring AMD Ryzen CPU
This latest release is the first laptop to include the new CPU from Ryzen and Linux preinstalled.
-
XZ Gets the All-Clear
The back door xz vulnerability has been officially reverted for Fedora 40 and versions 38 and 39 were never affected.
-
Canonical Collaborates with Qualcomm on New Venture
This new joint effort is geared toward bringing Ubuntu and Ubuntu Core to Qualcomm-powered devices.
-
Kodi 21.0 Open-Source Entertainment Hub Released
After a year of development, the award-winning Kodi cross-platform, media center software is now available with many new additions and improvements.
-
Linux Usage Increases in Two Key Areas
If market share is your thing, you'll be happy to know that Linux is on the rise in two areas that, if they keep climbing, could have serious meaning for Linux's future.
-
Vulnerability Discovered in xz Libraries
An urgent alert for Fedora 40 has been posted and users should pay attention.
-
Canonical Bumps LTS Support to 12 years
If you're worried that your Ubuntu LTS release won't be supported long enough to last, Canonical has a surprise for you in the form of 12 years of security coverage.
-
Fedora 40 Beta Released Soon
With the official release of Fedora 40 coming in April, it's almost time to download the beta and see what's new.
-
New Pentesting Distribution to Compete with Kali Linux
SnoopGod is now available for your testing needs
-
Juno Computers Launches Another Linux Laptop
If you're looking for a powerhouse laptop that runs Ubuntu, the Juno Computers Neptune 17 v6 should be on your radar.